[U-Boot] [PATCH] mmc: fix ERASE_GRP_DEF handling

Hannes Petermaier Hannes.Petermaier at br-automation.com
Tue Aug 12 07:47:46 CEST 2014


> Hi, Hannes.
Hi Jaehoon,

> > diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
> > index a26f3ce..52a8e36 100644
> > --- a/drivers/mmc/mmc.c
> > +++ b/drivers/mmc/mmc.c
> > @@ -1010,6 +1010,8 @@ static int mmc_startup(struct mmc *mmc)
> > 
> >           if (err)
> >              return err;
> > +         else
> > +            ext_csd[EXT_CSD_ERASE_GROUP_DEF] = 1;
> When is this value read?

a few lines above, have a look at line 967:
/* check  ext_csd version and capacity */
err = mmc_send_ext_csd(mmc, ext_csd);

> If i'm right, you means that it has to set before comparing with 
test_csd, right?
yes, exactly thats what i mean.

> It's reasonable, but i'm not sure that hard-coding is right.
why not ? we set the bit using mmc_switch, and only after success we alter 
our internal structure.

> 
> Best Regards,
> Jaehoon Chung

best regards,
Hannes





More information about the U-Boot mailing list