[U-Boot] [PATCH] kmp204x: set the ZL clk chips reset to power up only

[Valentin Longchamp]

On 08/12/2014 07:54 PM, York Sun wrote:
> On 07/17/2014 05:22 AM, Valentin Longchamp wrote:
>> There is the requirement on the chassis's backplane that when the clocks
>> are enabled, they should not disappear. Resetting theses chips at unit
> 
> I guess here "they" means the "clocks".


Yes, correct.
> 
>> reset also has the side effect that their clocks disappear.
> 
> What does "their" point to? Whose clocks?

This refers to the "chips", that provide the clocks, the ZL clocking chips.

> 
>>
>> To avoid this side effect, both the ZL chips are reset only in the event
>> of a power cycle.
>>
> 
> Do you mean "power up" here?

Yes, correct

> 
> I suggest you rephrase your commit message. It sounds twisting.

OK

> 
>> Signed-off-by: Valentin Longchamp <valentin.longchamp at keymile.com>
>> ---
>>
>>  board/keymile/kmp204x/kmp204x.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/board/keymile/kmp204x/kmp204x.c b/board/keymile/kmp204x/kmp204x.c
>> index 6bc8eb8..638b2a3 100644
>> --- a/board/keymile/kmp204x/kmp204x.c
>> +++ b/board/keymile/kmp204x/kmp204x.c
>> @@ -94,7 +94,7 @@ int board_early_init_f(void)
>>  	qrio_wdmask(BFTIC4_RST, true);
>>  
>>  	/* set the ZL30138's prstcfg to reset at power-up and unit reset only */
>> -	qrio_prstcfg(ZL30158_RST, PRSTCFG_POWUP_UNIT_RST);
>> +	qrio_prstcfg(ZL30158_RST, PRSTCFG_POWUP_RST);
>>  	/* and take it out of reset as soon as possible (needed for Hooper) */
>>  	qrio_prst(ZL30158_RST, false, false);
>>  
>> @@ -144,7 +144,7 @@ int misc_init_f(void)
>>  	qrio_prst(ETH_FRONT_PHY_RST, false, false);
>>  
>>  	/* set the ZL30343 prstcfg to reset at power-up and unit reset only */
>> -	qrio_prstcfg(ZL30343_RST, PRSTCFG_POWUP_UNIT_RST);
>> +	qrio_prstcfg(ZL30343_RST, PRSTCFG_POWUP_RST);
>>  	/* and enable the WD on it */
>>  	qrio_wdmask(ZL30343_RST, true);
> 
> You changed the macros here but not the comments.
> 
> York
>