[U-Boot] [PATCH v4 16/18] video: dcu: Add Sii9022A HDMI Transmitter support

[AlisonWang]

On 08/13/2014 11:45 PM, Alison Wang wrote:

> On LS1021ATWR, Silicon's Sii9022A HDMI Transmitter 
> is used. This patch adds the common setting for this 
> chip. 
> 

Shouldn't this driver stay under driver/video? It is for the HDMI
transmitter, 
not Freescale board specific, is it? 

[Alison Wang] It's just a simple register setting for Sii9022A on Freescale
board LS1021ATWR,
and not a regular video driver. I am not sure whether it should stay under
driver/video.

> 
> diff --git a/board/freescale/common/Makefile
> b/board/freescale/common/Makefile 
> index 22b57cc..808ddd0 100644 
> --- a/board/freescale/common/Makefile 
> +++ b/board/freescale/common/Makefile 
> @@ -34,6 +34,8 @@ ifndef CONFIG_RAMBOOT_PBL 
>  obj-$(CONFIG_FSL_FIXED_MMC_LOCATION)	+= sdhc_boot.o 
>  endif 
>   
> +obj-$(CONFIG_FSL_DCU_SII9022A)    += dcu_sii9022a.o 
> + 
>  obj-$(CONFIG_MPC8541CDS)	+= cds_pci_ft.o 
>  obj-$(CONFIG_MPC8548CDS)	+= cds_pci_ft.o 
>  obj-$(CONFIG_MPC8555CDS)	+= cds_pci_ft.o 
> diff --git a/board/freescale/common/dcu_sii9022a.c
> b/board/freescale/common/dcu_sii9022a.c 
> new file mode 100644 
> index 0000000..2da627e 
> --- /dev/null 
> +++ b/board/freescale/common/dcu_sii9022a.c 
> @@ -0,0 +1,153 @@ 
> +/* 
> + * Copyright 2014 Freescale Semiconductor, Inc. 
> + * 
> + * SPDX-License-Identifier:	GPL-2.0+ 
> + */ 
> + 
> +#include <asm/io.h> 
> +#include <common.h> 
> +#include <fsl_dcu_fb.h> 
>
I think you put the patches in wrong order. DCU driver has not been added
before 
this patch. 

[Alison Wang] Ok, I will change the order in v5.

Alison



--
View this message in context: http://u-boot.10912.n7.nabble.com/PATCH-v4-0-18-arm-ls102xa-Add-Freescale-LS102xA-SoC-and-LS1021AQDS-TWR-board-support-tp186703p186810.html
Sent from the U-Boot mailing list archive at Nabble.com.