[U-Boot] [PATCH 02/11] imx: ventana: added cputype env var

[Tim Harvey]

On Thu, Aug 14, 2014 at 8:23 AM, Stefano Babic <sbabic at denx.de> wrote:
> On 08/08/2014 07:35, Tim Harvey wrote:
>> There are many similarities between the IMX6QUAD/IMX6DUAL and there are
>> many similarities between the IMX6SOLO/IMX6DUALITE. Add a 'soctype' env
>> variable that tells you which type you have.
>>
>> Signed-off-by: Tim Harvey <tharvey at gateworks.com>
>> ---
>>  board/gateworks/gw_ventana/gw_ventana.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/board/gateworks/gw_ventana/gw_ventana.c b/board/gateworks/gw_ventana/gw_ventana.c
>> index a8fcb5d..de2336e 100644
>> --- a/board/gateworks/gw_ventana/gw_ventana.c
>> +++ b/board/gateworks/gw_ventana/gw_ventana.c
>> @@ -1264,6 +1264,7 @@ int misc_init_r(void)
>>               else if (is_cpu_type(MXC_CPU_MX6DL) ||
>>                        is_cpu_type(MXC_CPU_MX6SOLO))
>>                       cputype = "imx6dl";
>> +             setenv("soctype", cputype);
>
> So you have soc=mx6 and soctype=<value of cputype>, if CONFIG_SYS_SOC is
> set.
>
> Is it important to have both or you can simply redefine the variable "soc" ?
>
> Best regards,
> Stefano Babic
>

Hi Stefano,

Yes, I do feel its important, although the name and where its set is debatable.

There are enough similarities between an IMX6DUAL/IMX6QUAD vs an
IMX6SOLO/IMX6DUALLITE making it such that if your board supports all 4
CPU's, you would usually have just two device-tree files:
imx6q-<foo>.dtb (supporting both the QUAD and the DUAL soc variants)
and imx6dl-<foo>.dtb (supporting both the DUALLITE and SOLO soc
variants).

Regards,

Tim