[U-Boot] [PATCH v2] kconfig: convert Kconfig helper script into a shell script

Simon Glass sjg at chromium.org
Mon Aug 18 18:27:29 CEST 2014


Hi,

On 18 August 2014 10:20, Stephen Warren <swarren at wwwdotorg.org> wrote:

> On 08/16/2014 10:56 PM, Masahiro Yamada wrote:
>
>> Commit 51148790 added scripts/multiconfig.py written in Python 2
>> to adjust Kconfig for U-Boot.
>>
>> It has been hard for Python 3 users because Python 2 and Python 3
>> are not compatible with each other.
>>
>> We are not happy about adding a new host tool dependency
>> (in this case, Python version dependency) for the core build process.
>> After some discussion, we decided to use only basic tools.
>>
>> The script may get a bit unreadable by shell scripting, but we believe
>> it is worthwhile.
>>
>> In addition, this commit revives "<board>_config" target that is
>> equivalent to "<board>_defconfig" for backwards compatibility.
>> It is annoying to adjust various projects which use U-Boot.
>>
>
> Personally, I think this change isn't justified; I see no reason to
> replace the perfectly working existing script. Still, if that's what's
> desired...
>

Agreed, it seems unfortunate - long shell scripts are so much harder to
work with IMO. Is it really not possible to make code compatible with both?
Also we have lost the docs at the top of the file I think.

Regards,
Simon


More information about the U-Boot mailing list