[U-Boot] [UBOOT RFC PATCH 11/13] commom: usb: implement "__weak" functions to make compiler happy

Lukasz Majewski l.majewski at samsung.com
Tue Aug 19 10:28:11 CEST 2014


Hi Kishon,

> Implemented __weak functions for board_usb_cleanup,
> board_usb_gadget_handle_interrupts and usb_gadget_handle_interrupts
> to get of compiler errors in platforms that haven't implemented
> these functions.
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon at ti.com>
> ---
>  common/usb.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/common/usb.c b/common/usb.c
> index 60daa10..892bf7c 100644
> --- a/common/usb.c
> +++ b/common/usb.c
> @@ -1072,4 +1072,22 @@ int board_usb_init(int index, enum
> usb_init_type init) {
>  	return 0;
>  }
> +
> +__weak
> +int board_usb_cleanup(int index, enum usb_init_type init)
> +{
> +	return 0;
> +}

This needed before [PATCH 7/13]. Without it your code will cause u-boot
repository to not be bisectable.

> +
> +__weak
> +int board_usb_gadget_handle_interrupts(int index)
> +{
> +	return 0;
> +}
> +
> +__weak
> +int usb_gadget_handle_interrupts(void)
> +{
> +	return 0;
> +}
>  /* EOF */



-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group


More information about the U-Boot mailing list