[U-Boot] [PATCH v3] Makefile: remove generated boards.cfg within make distclean

[Masahiro Yamada]

Hi Roger,


On Wed, 20 Aug 2014 01:13:50 +0200
Roger Meier <roger at bufferoverflow.ch> wrote:

> Signed-off-by: Roger Meier <roger at bufferoverflow.ch>
> CC: Masahiro Yamada <yamada.m at jp.panasonic.com>
> CC: Tom Rini <trini at ti.com>
> CC: Wolfgang Denk <wd at denx.de>


Most people use 'Cc:' instead of 'CC:'.


$ git log v2013.01..v2014.07 | grep 'Cc:' | wc
   2007    8047   87385
$ git log v2013.01..v2014.07 | grep 'CC:' | wc
    147     598    6443




> diff --git a/Makefile b/Makefile
> index 666d291..6679408 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1285,7 +1285,8 @@ distclean: mrproper
>  		-o -name '*.bak' -o -name '#*#' -o -name '.*.orig' \
>  		-o -name '.*.rej' -o -name '*%' -o -name 'core' \
>  		-o -name '*.pyc' \) \
> -		-type f -print | xargs rm -f
> +		-type f -print | xargs rm -f \
> +	@rm -f boards.cfg
>  
>  backup:
>  	F=`basename $(srctree)` ; cd .. ; \


No.  You missed one of my comments against v2.

Please remove the backslash after "xargs rm -f".


Here, you are doing

@find ... | xargs rm -f @rm -f boards.cfg


that is, you are trying to delete
'@rm' as well as 'boards.cfg' if they exist.


Besides, you also need to fix buildman
as Simon suggested.


Please also cc Simon when you post the next version.




Best Regards
Masahiro Yamada