[U-Boot] [PATCH] nand/denali: Adding Denali NAND driver support
Masahiro Yamada
yamada.m at jp.panasonic.com
Wed Aug 20 05:47:34 CEST 2014
Hi Chin,
On Tue, 19 Aug 2014 04:47:40 -0500
Chin Liang See <clsee at altera.com> wrote:
> +
> +/* We need to buffer some data for some of the NAND core routines.
> + * The operations manage buffering that data. */
> +static void reset_buf(struct denali_nand_info *denali)
> +{
> + denali->buf.head = 0;
> + denali->buf.tail = 0;
> +}
I compared v8 and v9.
I noticed you changed this part
from
denali->buf.head = denali->buf.tail = 0;
to
denali->buf.head = 0;
denali->buf.tail = 0;
where nobody pointed out.
My question is,
foo = bar = 0 violates the codying style?
Anyway, this version worked on my board.
Signed-off-by: Masahiro Yamada <yamada.m at jp.panasonic.com>
Reviewed-by: Masahiro Yamada <yamada.m at jp.panasonic.com>
Tested-by: Masahiro Yamada <yamada.m at jp.panasonic.com>
Scott,
Could you do a quick review on this, please?
Best Regards
Masahiro Yamada
More information about the U-Boot
mailing list