[U-Boot] [PATCH] arm: tegra: initial support for apalis t30
Marcel Ziswiler
marcel at ziswiler.com
Wed Aug 20 09:35:37 CEST 2014
On Tue, 2014-08-19 at 15:42 -0600, Stephen Warren wrote:
> At a quick glance this looks OK,
> Acked-by: Stephen Warren <swarren at nvidia.com>
Thanks mate. Glad to get ready for more PCIe action now.
> One very minor nit:
>
> > diff --git a/arch/arm/dts/tegra30-apalis.dts b/arch/arm/dts/tegra30-apalis.dts
>
> > + /* GEN1_I2C: I2C1_SDA/SCL on MXM3 pin 209/211 (e.g. RTC on carrier
> > + board) */
>
> That comment style is odd. It should be:
>
> /*
> * Text here
> * More here
> */
You're absolutely right. I believe you and/or Stefan already reminded me
about that one at least once during my kernel submission which I fixed
in that respect. Don't know how it sneaked itself back into this one now
again. Please forgive. I owe some beer.
More information about the U-Boot
mailing list