[U-Boot] Patman bug report: Commit-notes not working

Masahiro Yamada yamada.m at jp.panasonic.com
Thu Aug 21 03:19:11 CEST 2014


Hi Simon,



I found 'Commit-notes:' is not working correctly.
It seems a bit fatal.  Could you fix it asap, please?



I bisected and the first bad commit is:

commit cda2a611520e679495e7d2cf8e436b0df9afc675
patman: Move the 'git log' command into a function




How to repeat the bug
---------------------

For example, assume we are trying to send a series
which consists of two patches.


git log looks like this:



commit 757799f581ca366f26af6d9bbd52dccf90a162c1
Author: Masahiro Yamada <yamada.m at jp.panasonic.com>
Date:   Thu Aug 21 09:58:21 2014 +0900

    bar: patch2
    
    Commit-notes:
    
    Blah Blah
    
    END

commit 9ec777cd2ceeff2861cc38cea211440e4c1dea6b
Author: Masahiro Yamada <yamada.m at jp.panasonic.com>
Date:   Thu Aug 21 09:57:59 2014 +0900

    foo: patch1







Commit-notes "Blah Blah" should belong to the second patch.


But when I run "tools/patman/patman -t -c 2",
I see the commit-notes moves to the first patch like follows:




From 9ec777cd2ceeff2861cc38cea211440e4c1dea6b Mon Sep 17 00:00:00 2001
From: Masahiro Yamada <yamada.m at jp.panasonic.com>
Date: Thu, 21 Aug 2014 09:57:59 +0900
Subject: [PATCH 1/2] foo: patch1

Signed-off-by: Masahiro Yamada <yamada.m at jp.panasonic.com>
---

Blah Blah


 README | 2 ++
 1 file changed, 2 insertions(+)








Best Regards
Masahiro Yamada



More information about the U-Boot mailing list