[U-Boot] [PATCH] arm: fix missing exception handling

[Christian Riesch]

Benoît,

On Wed, Aug 20, 2014 at 12:47 PM, Benoît Thébaudeau
<benoit.thebaudeau.dev at gmail.com> wrote:
> On Wed, Aug 20, 2014 at 9:21 AM, Christian Riesch
> <christian.riesch at omicron.at> wrote:
>> On Tue, Aug 19, 2014 at 8:35 PM, Benoît Thébaudeau
>> <benoit.thebaudeau.dev at gmail.com> wrote:
>>> Commit 41623c9 'arm: move exception handling out of start.S files' missed some
>>> linker scripts. Hence, some boards no longer had exception handling linked since
>>> this commit. Restore the original behavior by adding the .vectors section to
>>> these linker scripts.
>>>
>>> Signed-off-by: Benoît Thébaudeau <benoit.thebaudeau.dev at gmail.com>
>>> Cc: Albert ARIBAUD <albert.u.boot at aribaud.net>
>>
>> Does this really _fix_ exception handling for all of these boards (as
>> your message subject states) or just restore the state before commit
>> 41623c9? I believe exception handling has never worked for most of
>> these boards, they don't use it. See the discussion in [1], in
>> particular [2] and [3].
>>
>> Regards, Christian
>>
>> [1] http://marc.info/?t=140247105400001&r=1&w=2
>> [2] http://marc.info/?l=u-boot&m=140309659906074&w=2
>> [3] http://marc.info/?l=u-boot&m=140450616517545&w=2
>
> The issue is that commit 41623c9 silently removed exception handling
> for many boards. Whether it was working or not for these boards before
> this commit is another issue. My patch only fixes _missing_ exception
> handling, not exception handling itself. I had discussed that with
> Albert here:
> http://lists.denx.de/pipermail/u-boot/2014-July/183073.html

Thanks for the pointer to the discussion.

> What do you suggest?
>  - Changing the wording? In which way?

Yes, how about "Add missing .vectors section to linker scripts"?
Regards, Christian