[U-Boot] [PATCH 1/2] dfu: Provide means to find difference between dfu-util -e and -R

[Lukasz Majewski]

On Fri, 22 Aug 2014 12:06:03 -0600
Stephen Warren <swarren at wwwdotorg.org> wrote:

> 
> On 08/22/2014 08:08 AM, Lukasz Majewski wrote:
> > This commit provides distinction between DFU device detach and
> > reset. The -R behavior is preserved with proper handling of the
> > dfu-util's -e switch, which detach the DFU device.
> >
> > By running dfu-util -e; one can force device to finish the
> > execution of dfu command on target and execute some other scripted
> > commands.
> 
> This sounds extremely useful; I wonder if UMS could have the same
> feature?

It is worth considering. I will think about this

> 
> > diff --git a/common/cmd_dfu.c b/common/cmd_dfu.c
> 
> > +static bool dfu_reset;
> 
> Can't this be a local variable inside the do_dfu() function?

I think I can put this variable there.

> 
> Aside from that,
> Reviewed-by: Stephen Warren <swarren at nvidia.com>

Best regards,
Lukasz Majewski
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140822/209561eb/attachment.pgp>