[U-Boot] [PATCH v3 1/2] image: fix bootm failure for FIT image

[Simon Glass]

Hi Tom,

On Aug 22, 2014 3:54 PM, "Tom Rini" <trini at ti.com> wrote:
>
> On Fri, Aug 22, 2014 at 05:38:59PM -0400, Tom Rini wrote:
> > On Fri, Aug 22, 2014 at 02:17:53PM -0600, Simon Glass wrote:
> > > Hi Bryan,
> > >
> > > On 15 August 2014 17:51, Bryan Wu <cooloney at gmail.com> wrote:
> > > >
> > > > Commit b3dd64f5d537 "bootm: use genimg_get_kernel_addr()" introduced
> > > > a bug for booting FIT image. It's because calling fit_parse_config()
> > > > twice will give us wrong value in img_addr.
> > > >
> > > > Add a new function genimg_get_kernel_addr_fit() whichl will always
> > > > return fit_uname_config and fit_uname_kernel for CONFIG_FIT.
> > > > genimg_get_kernel_addr() will ignore those to parameters.
> > > >
> > > > Reported-by: York Sun <yorksun at freescale.com>
> > > > Signed-off-by: Bryan Wu <pengw at nvidia.com>
> > >
> > > I think the function comment should be in the header file, but it's
> > > not important for now.
> > >
> > > The image.h file has a whitespace problem - tabs instead of spaces. If
> > > you run patman you will see it.
> > >
> > > Unfortunately the tests still fail due to two other issues. I'll send
> > > a few patches.
> >
> > ... but we're believing things are all fixed now, right?
>
> ... I assume so since I can just 'bootm' a FIT image now and before
> things hang, so pushing shortly.

Yes, also see my two patches. Would like to leave those for discussion for
a bit though due to the ramdisk change.

Regards,
Simon

>
> --
> Tom