[U-Boot] [PATCH] mvebu_mmc: Driver addition

Stefan Roese sr at denx.de
Mon Aug 25 12:58:21 CEST 2014


On 25.08.2014 12:53, Mario Schuknecht wrote:
>         +/*
>         + * Set window register.
>         + */
>         +static void mvebu_window_setup(void)
>         +{
>         +       int i;
>         +
>         +        for (i = 0; i < 4; i++) {
>         +               mvebu_mmc_write(WINDOW_CTRL(i)__, 0);
>         +               mvebu_mmc_write(WINDOW_BASE(i)__, 0);
>         +        }
>
>
>     Spaces instead of tabs for indentation. Please fix globally
>     (checkpatch clean)
>
> A question. What is meant by "Spaces instead of tabs for indentation"?
> In the whole file (and other files) tabs are used for indentation.

No. I meant, use only tabs for indentation. In the line above you have 
used spaces instead of tabs. Checkpatch should warn about those issues. 
Its recommended to run it before sending patches to the list.

Thanks,
Stefan



More information about the U-Boot mailing list