[U-Boot] [PATCH v9 0/14] Add some missing buildman features and deprecate MAKEALL

[Simon Glass]

Hi Tom,

On 25 August 2014 14:21, Tom Rini <trini at ti.com> wrote:
> On Mon, Aug 25, 2014 at 01:00:05PM -0600, Simon Glass wrote:
>> Hi Tom,
>>
>> On 25 August 2014 12:54, Tom Rini <trini at ti.com> wrote:
>> > On Mon, Aug 25, 2014 at 09:58:21AM -0600, Simon Glass wrote:
>> >
>> >> Buildman has been around for a little over a year and is used by a fair
>> >> number of U-Boot developers. However quite a few people still use MAKEALL.
>> >>
>> >> Buildman was intended to replace MAKEALL, so perhaps now is a good time to
>> >> start that process.
>> >>
>> >> The reasons to deprecate MAKEALL are:
>> >> - We don't want to maintain two build systems
>> >> - Buildman is typically faster
>> >> - Buildman has a lot more features
>> >>
>> >> This series adds a few features to buildman to fill some gaps, adds some
>> >> information into the README on how to migrate from MAKEALL, and adds a
>> >> deprecation message to MAKEALL.
>> >
>> > I'm testing this out again in the Ubuntu 10.04 / LSF environment I have
>> > access to but so far I'm still finding that test for --no-decorate isn't
>> > working and I have to manually set it to False.
>>
>> Oh dear. I wrote a test for this in the second series. So if you apply
>> that series, do the tests pass? It is in func_test.py and is called
>> testGitSetup().
>
> With my local kludge removed yes, all tests pass.

It's quite mysterious. I installed Ubuntu 10.04 and it runs python 2.6.5.

The --no-decorate patch does work, although it does print an error. I
could suppress that easily enough, just adding another arg
'capture_stderr=True' to the RunPipe() call in gitutil.py.Setup().

I see a problem with timedelta not having total_seconds. After that
the threading dies. So I'm quite impressed you can get buildman to run
at all. Are you using one of the later 10.04 releases?

Regards,
Simon