[U-Boot] [PATCH] samsung: s5p_goni: fix: Add missing definitions for G_DNL_UMS gadget

Minkyu Kang mk7.kang at samsung.com
Thu Aug 28 13:33:14 CEST 2014


On 25/08/14 16:26, Lukasz Majewski wrote:
> Hi Tom,
> 
>> On 08/22/2014 09:12 AM, Lukasz Majewski wrote:
>>> The commit (SHA1: 8fc171318e352) reintroduced correct values for
>>> vendor and product IDs required for UMS gadget to work properly
>>> either at Windows or Linux.
>>>
>>> This data was missing for GONI target, so this commit corrects this
>>> mistake.
>>>
>>> Signed-off-by: Lukasz Majewski <l.majewski at samsung.com>
>>> ---
>>>  include/configs/s5p_goni.h | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/include/configs/s5p_goni.h b/include/configs/s5p_goni.h
>>> index 6e795bf..a51215d 100644
>>> --- a/include/configs/s5p_goni.h
>>> +++ b/include/configs/s5p_goni.h
>>> @@ -91,6 +91,8 @@
>>>  #define CONFIG_G_DNL_PRODUCT_NUM 0x6601
>>>  #define CONFIG_G_DNL_THOR_VENDOR_NUM CONFIG_G_DNL_VENDOR_NUM
>>>  #define CONFIG_G_DNL_THOR_PRODUCT_NUM 0x685D
>>> +#define CONFIG_G_DNL_UMS_VENDOR_NUM 0x0525
>>> +#define CONFIG_G_DNL_UMS_PRODUCT_NUM 0xA4A5
>>>  #define CONFIG_G_DNL_MANUFACTURER "Samsung"
>>>  
>>>  /* Actual modem binary size is 16MiB. Add 2MiB for bad block
>>> handling */
>>>
>>
>> Acked-by: Robert Baldyga <r.baldyga at samsung.com>
> 
> Tom, since Robert - the maintainer of the GONI board has acked the
> patch and the patch itself adds only missing defines, could you pull
> this patch to mainline ASAP?
> 
> It fixes build breaks caused by the GONI board :-)
> 

If Tom will merge it to mainline then,

Acked-by: Minkyu Kang <mk7.kang at samsung.com>

Thanks,
Minkyu Kang.


More information about the U-Boot mailing list