[U-Boot] ARM: Fix overflow in MMU setup

Tom Rini trini at ti.com
Sat Aug 30 17:14:26 CEST 2014


On Mon, Aug 04, 2014 at 01:45:46AM +0200, Marek Vasut wrote:

> The patch fixes a corner case where adding size to DRAM start resulted
> in a value (1 << 32), which in turn overflew the u32 computation, which
> resulted in 0 and it therefore prevented correct setup of the MMU tables.
> 
> The addition of DRAM bank start and it's size can end up right at the end
> of the address space in the special case of a machine with enough memory.
> To prevent this overflow, shift the start and size separately and add them
> only after they were shifted.
> 
> Hopefully, we only have systems in tree which have DRAM size aligned to
> 1MiB boundary. If not, this patch would break such systems. On the other
> hand, such system would be broken by design anyway.
> 
> Signed-off-by: Marek Vasut <marex at denx.de>
> Cc: Albert ARIBAUD <albert.u.boot at aribaud.net>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140830/a1488a2c/attachment.pgp>


More information about the U-Boot mailing list