[U-Boot] [PATCH 4/7] arm: rmobile: lager: Halt clock prior to booting kernel

[Wolfgang Denk]

Dear Nobuhiro,

In message <1417417556-23946-4-git-send-email-nobuhiro.iwamatsu.yj at renesas.com> you wrote:
> Before a kernel boots, GPIO, SYS-DMAC, QSPI and MSIOF clock
> is halted.
> 
> Signed-off-by: Hisashi Nakamura <hisashi.nakamura.ak at renesas.com>
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj at renesas.com>

The data structures and the code are all repeated for this patch and
the following patches:

	[PATCH 4/7] arm: rmobile: lager: Halt clock prior to booting kernel
	[PATCH 5/7] arm: rmobile: koelsch: Halt clock prior to booting kernel
	[U-Boot] [PATCH 6/7] arm: rmobile: alt: Halt clock prior to booting kernel
	[PATCH 7/7] arm: rmobile: gose: Halt clock prior to booting kernel

Can you please move the code to a common place so we have it only
once?

> +} mstptbl[] = {
> +	[0] = { SMSTPCR0,  0x00640801, 0x00400001,
> +		RMSTPCR0,  0x00640801, 0x00000000 },
> +	[1] = { SMSTPCR1,  0xDB6E9BDF, 0x00000000,
> +		RMSTPCR1,  0xDB6E9BDF, 0x00000000 },
> +	[2] = { SMSTPCR2,  0x300DA1FC, 0x000CA120,
> +		RMSTPCR2,  0x300DA1FC, 0x00000000 },
> +	[3] = { SMSTPCR3,  0xF08CF831, 0x00000000,
> +		RMSTPCR3,  0xF08CF831, 0x00000000 },
> +	[4] = { SMSTPCR4,  0x80000184, 0x00000180,
> +		RMSTPCR4,  0x80000184, 0x00000000 },
> +	[5] = { SMSTPCR5,  0x44C00046, 0x00000000,
> +		RMSTPCR5,  0x44C00046, 0x00000000 },
> +	[7] = { SMSTPCR7,  0x07F30718, 0x00200000,
> +		RMSTPCR7,  0x07F30718, 0x00000000 },
> +	[8] = { SMSTPCR8,  0x01F0FF84, 0x00000000,
> +		RMSTPCR8,  0x01F0FF84, 0x00000000 },
> +	[9] = { SMSTPCR9,  0xF5979FCF, 0x00021F80,
> +		RMSTPCR9,  0xF5979FCF, 0x00001F80 },
> +	[10] = { SMSTPCR10, 0xFFFEFFE0, 0x00000000,
> +		 RMSTPCR10, 0xFFFEFFE0, 0x00000000 },
> +	[11] = { SMSTPCR11, 0x00000000, 0x00000000,
> +		 RMSTPCR11, 0x00000000, 0x00000000 },
> +};

Also, these data look pretty much the same to me, with only minor
differences in some bits.  If we use some defines instead of the
magic numbers this could probably help to see the common part and the
differences in the data. We probably don't need board-specific data in
the code, and can move this to the configuration files?

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Obviously, a major malfunction has occurred."
              -- Steve Nesbitt, voice of Mission Control, January 28,
                 1986, as the shuttle Challenger exploded within view
                 of the grandstands.