[U-Boot] [PATCH 2/2 v2] exynos5420: fix compilation without parade video

[Simon Glass]

Hi,

On 1 December 2014 at 03:06, Sjoerd Simons
<sjoerd.simons at collabora.co.uk> wrote:
> Hey Minkyu,
>
> On Mon, 2014-12-01 at 14:24 +0900, Minkyu Kang wrote:
>> > --- a/arch/arm/include/asm/arch-exynos/system.h
>> > +++ b/arch/arm/include/asm/arch-exynos/system.h
>> > @@ -42,6 +42,10 @@ void set_system_display_ctrl(void);
>> >  int exynos_lcd_early_init(const void *blob);
>> >
>> >  /* Initialize the Parade dP<->LVDS bridge if present */
>> > +#ifdef CONFIG_VIDEO_PARADE
>> >  int parade_init(const void *blob);
>> > +#else
>> > +static inline int parade_init(const void *blob) { return -1; }
>> > +#endif
>>
>> Actually, it does not related with this patch..
>> and I know that you are not an author.
>> But.. I'd like ask you, why parade_init function is in exynos header file?
>> If you are agreed, could you please make new header file? (e.g: include/parade.h)
>
> I'm not sure why it's in the exynos header file, it being there
> surprised me as well. I'm happy to move it around in a next version of
> the patch though.
>
>> And I think you missed removing the CONFIG_VIDEO_PARADE at peach-pi.h
>
> That's on purpose, in the discussion with Simon Glass it became clear
> that the intention is to start minimizing peach-pi.h (and hopefully make
> it unnecessary). So i left peach-pi.h untouched for now, in order for a
> later patchset to clean up the configuration more.

I'll take a look at this next week. Particularly for Pit and Pi we
should be able to use the same config (SDRAM is the only barrier).

Regards,
Simon