[U-Boot] [PATCH V2 00/12] cleanup and refactor lcd.c

Stephen Warren swarren at wwwdotorg.org
Tue Dec 2 05:10:54 CET 2014


On 11/30/2014 05:29 AM, Nikita Kiryanov wrote:
> This series is a first step towards an end goal of merging all CONFIG_LCD
> related functionality into CONFIG_VIDEO code. My plan is to start by refactoring
> lcd.c into something cleaner (less ifdefs) and more modular (split code into
> multiple files), then possibly refactor CONFIG_VIDEO code if needed, and then
> finally: move CONFIG_LCD related functionality over to CONFIG_VIDEO code,
> replacing as much CONFIG_LCD related code with CONFIG_VIDEO related code as
> possible.
> 
> This specific step eliminates some unused code and refactors lcd console stuff
> into its own file.
> 
> In V2 I broke the last patch of the original series ("lcd: refactor lcd console
> stuff into its own file") into multiple patches to make it clear what changes
> had to be done in order to refactor the lcd console code into its own file.
> These preparatory patches ("lcd: rename console_(row|col)" to
> "lcd: make lcd_drawchars() independant of lcd_base") are meant to illustrate
> exactly what changed and where in the transition from lcd.c to lcd_console.c,
> and are not necesserily code improvements when viewed out of context.
> 
> Additional changes in V2:
> 	- Added documentation for the new functions.
> 
> The whole series was rebased over current mainline, and compile tested for arm
> and powerpc.

HDMI support still seems to work on Raspberry Pi with this applied, so,
Tested-by: Stephen Warren <swarren at wwwdotorg.org>



More information about the U-Boot mailing list