[U-Boot] [PATCH v10 4/4] Odroid-XU3: Add entry for DTS EHCI GPIO

[Sjoerd Simons]

+ajaykumar

On Tue, 2014-12-02 at 10:25 -0700, Simon Glass wrote:
> Hi,
> 
> On 2 December 2014 at 00:07, Hyungwon Hwang <human.hwang at samsung.com> wrote:
> > From: Sjoerd Simons <sjoerd.simons at collabora.co.uk>
> >
> > Add samsung,vbus-gpio information for the XU3. This allows the usage of
> > the EHCI controller on the XU3, which is connected to the SMSC LAN9514
> > chip (usb hub + network).
> >
> > Note that this patch doesn't enable support for USB/USB networking in
> > the default config as makes the u-boot binary too big for the current odroid
> > setup.
> >
> > Signed-off-by: Sjoerd Simons <sjoerd.simons at collabora.co.uk>
> > Signed-off-by: Hyungwon Hwang <human.hwang at samsung.com>
> > Cc: Minkyu Kang <mk7.kang at samsung.com>
> > Cc: Lukasz Majewski <l.majewski at samsung.com>
> > Cc: Sjoerd Simons <sjoerd.simons at collabora.co.uk>
> > Cc: Javier Martinez Canillas <javier at dowhile0.org>
> > Cc: Simon Glass <sjg at chromium.org>
> > ---
> > Changes for v10:
> > - Newly added
> >
> >  arch/arm/dts/exynos5422-odroidxu3.dts | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/arch/arm/dts/exynos5422-odroidxu3.dts b/arch/arm/dts/exynos5422-odroidxu3.dts
> > index cff32a9..be20f1b 100644
> > --- a/arch/arm/dts/exynos5422-odroidxu3.dts
> > +++ b/arch/arm/dts/exynos5422-odroidxu3.dts
> > @@ -31,6 +31,10 @@
> >                         0xb0000000 0xea00000>;
> >         };
> >
> > +       ehci at 12110000 {
> > +               samsung,vbus-gpio = <&gpio 0x316 0>; /* X26 */
> 
> Are you sure this is right? By my count this should be 0x66, not
> 0x316. This might be historical.

Yes you're right! I copied the number from the exynos5250-smdk5250.dts
without double-checking (even though i fixed the exact same isseu for
snow recently, doh). 

Please drop this patch from the set for now, and i'll send an updated
one seperately. But that shouldn't block merging the other patches in
this set. 

> It almost feels like you could drop this patch until you actually have
> working USB support.

USB does work, but it turns out that's because board_usb_vbus_init in
smdk5420 hardcodes turning on GPIO X26 (which happens to be correct for
XU3).. Which interestingly collides with exynos_lcd_power_on which
hardcodes using GPIO X26 for the EDP_HPD (as used on the snow/peach
boards).

So looks like some more things to fix :)

-- 
Sjoerd Simons <sjoerd.simons at collabora.co.uk>
Collabora Ltd.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 6170 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141203/5798e21c/attachment.bin>