[U-Boot] [PATCH 21/25] x86: Include FSP and CMC binary in the u-boot.rom build rules

[Bin Meng]

Hi Simon,

On Fri, Dec 5, 2014 at 7:57 AM, Simon Glass <sjg at chromium.org> wrote:
> Hi Bin,
>
> On 4 December 2014 at 08:03, Bin Meng <bmeng.cn at gmail.com> wrote:
>> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
>> ---
>>  Makefile | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/Makefile b/Makefile
>> index c9ae77b..abfb74b 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -976,6 +976,14 @@ ifneq ($(CONFIG_HAVE_MRC),)
>>  IFDTOOL_FLAGS += -w $(CONFIG_X86_MRC_START):$(srctree)/board/$(BOARDDIR)/mrc.bin
>>  endif
>>
>> +ifneq ($(CONFIG_HAVE_FSP),)
>> +IFDTOOL_FLAGS += -w $(CONFIG_FSP_LOCATION):$(CONFIG_FSP_FILE)
>
> Can we stay consistent - e.g. START instead of LOCATION? or ADDR?
> Granted it's not 100% consistent now.

Sure. I believe we can use ADDR for all these blobs.

>> +endif
>> +
>> +ifneq ($(CONFIG_HAVE_CMC),)
>> +IFDTOOL_FLAGS += -w $(CONFIG_CMC_LOCATION):$(CONFIG_CMC_FILE)
>> +endif
>> +
>>  ifneq ($(CONFIG_X86_OPTION_ROM_ADDR),)
>>  IFDTOOL_FLAGS += -w $(CONFIG_X86_OPTION_ROM_ADDR):$(srctree)/board/$(BOARDDIR)/$(CONFIG_X86_OPTION_ROM_FILENAME)
>>  endif
>> --
>> 1.8.2.1
>>
>
> Regards,
> Simon

Regards,
Bin