[U-Boot] [PATCH v2] odroid-XU3: Add entry for DTS EHCI GPIO

[Hyungwon Hwang]

Dear all,

On Mon, 08 Dec 2014 19:36:46 -0800
Suriyan Ramasami <suriyan.r at gmail.com> wrote:

> Hello Hyungwon Hwang,
> 
> On Mon, Dec 8, 2014 at 7:01 PM, Hyungwon Hwang
> <human.hwang at samsung.com> wrote:
> > Dear Sjoerd,
> >
> > On Fri, 05 Dec 2014 21:26:10 +0100
> > Sjoerd Simons <sjoerd.simons at collabora.co.uk> wrote:
> >
> >> Add samsung,vbus-gpio information for the XU3. This allows the
> >> usage of the EHCI controller on the XU3, which is connected to the
> >> SMSC LAN9514 chip (usb hub + network).
> >>
> >> Signed-off-by: Sjoerd Simons <sjoerd.simons at collabora.co.uk>
> >> ---
> >> Changes since v1:
> >>   + Correct gpio number
> >>   + Add USB configuration in the odroid XU3 default config
> >>
> >> Hyungwon could you add this one to your XU3 patchset if you send a
> >> next version (assuming it looks good)?
> >>
> >
> > Does it work only with this patch? I applied this patch on top of my
> > patchset, and connected the ethernet cable to the device. But it
> > seemed not working. Is there anything else that I should do for
> > test?
> >
> >> For usb storage/network support this patch should be combined
> >> with the exynos configuration tweaks patch i submited earlier to
> >> the list: Exynos: Move down common USB configuration
> >>
> >>  arch/arm/dts/exynos5422-odroidxu3.dts | 4 ++++
> >>  include/configs/odroid_xu3.h          | 4 ++++
> >>  2 files changed, 8 insertions(+)
> >>
> >> diff --git a/arch/arm/dts/exynos5422-odroidxu3.dts
> >> b/arch/arm/dts/exynos5422-odroidxu3.dts index cff32a9..79a7acd
> >> 100644 --- a/arch/arm/dts/exynos5422-odroidxu3.dts
> >> +++ b/arch/arm/dts/exynos5422-odroidxu3.dts
> >> @@ -31,6 +31,10 @@
> >>                       0xb0000000 0xea00000>;
> >>       };
> >>
> >> +     ehci at 12110000 {
> >> +             samsung,vbus-gpio = <&gpio 0x66 0>; /* X26 */
> >> +     };
> >> +
> >>       serial at 12C20000 {
> >>               status="okay";
> >>       };
> >> diff --git a/include/configs/odroid_xu3.h
> >> b/include/configs/odroid_xu3.h index 88bb98d..aa0c142 100644
> >> --- a/include/configs/odroid_xu3.h
> >> +++ b/include/configs/odroid_xu3.h
> >> @@ -47,6 +47,10 @@
> >>
> >>  #define
> >> CONFIG_DEFAULT_CONSOLE                "console=ttySAC2,115200n8\0"
> >> +/* USB */
> >> +#define CONFIG_USB_EHCI
> >> +#define CONFIG_USB_EHCI_EXYNOS
> >> +
> >>  /* FIXME: MUST BE REMOVED AFTER TMU IS TURNED ON */
> >>  #undef CONFIG_EXYNOS_TMU
> >>  #undef CONFIG_TMU_CMD_DTT
> >
> 
> In odroid_xu3.h you might want to add the below as well (for LAN +
> USB storage)
> 
> +/* Enable USB */
> +#define CONFIG_CMD_USB
> +#define CONFIG_USB_EHCI
> +#define CONFIG_USB_EHCI_EXYNOS
> +#define CONFIG_USB_STORAGE
> +#define CONFIG_CMD_DHCP
> +#define CONFIG_USB_HOST_ETHER
> +#define CONFIG_USB_ETHER_SMSC95XX
> 

Thanks for your reply. It works after above configs added.

It seems all configs which Suriyan specified are needed. Even though
DHCP can be useless depending on the network situation. Sjoerd, How
about add above configs for odroid_xu3.h?

Also, I think it is better to commit this patch separately with my
patchset, because it took too long from when the first patch
submitted, and I really want to make it merged with at least minimum
functionalities.

> Thanks
> - Suriyan
> > Best regards,
> > Hyungwon Hwang
> > _______________________________________________
> > U-Boot mailing list
> > U-Boot at lists.denx.de
> > http://lists.denx.de/mailman/listinfo/u-boot

Best regards,
Hyungwon Hwang