[U-Boot] [PATCH v5 01/11] dm: i2c: Add a uclass for I2C

[Masahiro Yamada]

Hi Simon,

On Mon, 8 Dec 2014 22:31:59 -0700
Simon Glass <sjg at chromium.org> wrote:

> Hi,
> 
> On Dec 5, 2014 8:32 AM, "Simon Glass" <sjg at chromium.org> wrote:
> >
> > The uclass implements the same operations as the current I2C framework but
> > makes some changes to make it fit driver model better:
> >
> > - Remove the chip address from API calls
> > - Remove the address length from API calls
> > - Remove concept of 'current' I2C bus
> > - Drop all existing init functions
> >
> > Acked-by: Heiko Schocher <hs at denx.de>
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> > ---
> >
> > Changes in v5:
> > - Add a function comment for i2c_probe_chip()
> > - Add an assert for offset_len in i2c_setup_offset()
> > - Add more detail to return value comment on get_buf_speed()
> > - Add more detail to return value comment on xfer() method
> > - Fix -INVAL typo
> > - Make i2c_get_bus_speed() independent of i2c_set_bus_speed()
> > - Split DM_I2C_CHIP_RD_ADDRESS into read and write varaints
> > - Update comments in struct i2c_msg to allow buf to be NULL
> > - Use a NULL buffer in i2c_probe_chip()
> 
> Any. Ore comments please? Otherwise I will retest and apply this version.


Sorry, I have been pretty busy early of this week.

Hopefully I will have some time to test this version tomorrow
and will issue my Reviewed-by credit.
Please wait a couple of days.



Best Regards
Masahiro Yamada