[U-Boot] [PATCH v5 05/11] dm: i2c: Add an I2C EEPROM simulator

[Masahiro Yamada]

Hi Simon,

Some minor comments.


On Fri,  5 Dec 2014 08:32:08 -0700
Simon Glass <sjg at chromium.org> wrote:

> +int sandbox_i2c_probe_chip(struct udevice *bus, uint chip_addr, uint chip_flags)
> +{

static ??


> +	/* Always let probe succeed */
> +	printf("%s: Detected probe\n", __func__);
> +	return 0;
> +}
> +
> +struct dm_i2c_ops sandbox_i2c_emul_ops = {
> +	.xfer = sandbox_i2c_eeprom_xfer,
> +	.probe_chip = sandbox_i2c_probe_chip,
> +};

Are you using .probe_chip ?
(Or planning to use it in the future?)

sandbox-i2c does not use a dedicated .probe_chip handler.


Best Regards
Masahiro Yamada