[U-Boot] [PATCH v6 04/11] dm: i2c: Add a sandbox I2C driver

[Masahiro Yamada]

Hi Simon,



On Wed, 10 Dec 2014 10:16:30 -0700
Simon Glass <sjg at chromium.org> wrote:

> Hi Masahiro,
> 
> On 10 December 2014 at 10:02, Masahiro YAMADA <yamada.m at jp.panasonic.com> wrote:
> > Hi Simon,
> >
> >
> >
> > 2014-12-11 0:55 GMT+09:00 Simon Glass <sjg at chromium.org>:
> >> This driver includes some test features such as only supporting certain
> >> bus speeds. It passes its I2C traffic through to an emulator.
> >>
> >> Acked-by: Heiko Schocher <hs at denx.de>
> >> Signed-off-by: Simon Glass <sjg at chromium.org>
> >> ---
> >>
> >> Changes in v6:
> >> - Drop a stale comment
> >> - Pass value from i2c_get_chip() to get_emul()
> >> - Use dm_scan_fdt_node() to find emulator
> >
> >
> >
> > When I run "i2c probe" on a real hardware,
> > generic-i2c is only added to slave-addresses that have responded.
> >
> > On sandbox, only 0x2c and 0x59 respond, but generic-i2c is added
> > to all the slave-addresses.
> > It looks funny.
> >
> > Is this a bug?
> 
> Not really - the driver is set to allow a probe on any chip. I suppose
> we could change it, but then we would have to change the tests to add
> the ability to tell it which things to respond to.
> 


OK, then

Reviewed-by: Masahiro Yamada <yamada.m at jp.panasonic.com>


Now I am satisfied with the whole of this series
and agree to get it in.

Thanks for your hard work!





Best Regards
Masahiro Yamada