[U-Boot] [PATCH 13/13] ARM: atmel: sama5d4_xplained: enable spl support

[Bo Shen]

Hi Robert Nelson,

On 12/11/2014 05:35 AM, Robert Nelson wrote:
>> +
>> >+#ifdef CONFIG_SYS_USE_MMC
>> >+#define CONFIG_SPL_LDSCRIPT            arch/arm/cpu/at91-common/u-boot-spl.lds
>> >+#define CONFIG_SPL_MMC_SUPPORT
>> >+#define CONFIG_SYS_U_BOOT_MAX_SIZE_SECTORS     0x400
>> >+#define CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR 0x200
>> >+#define CONFIG_SYS_MMC_SD_FS_BOOT_PARTITION    1
> Hi Bo,
>
> You have an extra "_" there: (MMC_SD) -> (MMCSD), it should be:
>
> #define  CONFIG_SYS_MMCSD_FS_BOOT_PARTITION 1
>
> build error:
>
> common/spl/spl_mmc.c: In function ‘spl_mmc_load_image’:
> common/spl/spl_mmc.c:135:6: error:
> ‘CONFIG_SYS_MMCSD_FS_BOOT_PARTITION’ undeclared (first use in this
> function)
>        CONFIG_SYS_MMCSD_FS_BOOT_PARTITION,
>        ^
> common/spl/spl_mmc.c:135:6: note: each undeclared identifier is
> reported only once for each function it appears in
> scripts/Makefile.build:275: recipe for target 'spl/common/spl/spl_mmc.o' failed
> make[2]: *** [spl/common/spl/spl_mmc.o] Error 1
> scripts/Makefile.spl:212: recipe for target 'spl/common/spl' failed
> make[1]: *** [spl/common/spl] Error 2
> make[1]: *** Waiting for unfinished jobs....

Do you test this patch series based on u-boot master branch?
I use "git grep CONFIG_SYS_MMCSD_FS_BOOT_PARTITION", and don't find any 
information about it.

Using "git grep CONFIG_SYS_MMC_SD_FS_BOOT_PARTITION" show many files use 
it. And the following commit introduced this name:
--->8---
commit 205b4f33cfe58268df7d433f2da515fe660afd9c
Author: Guillaume GARDET <guillaume.gardet at free.fr>
Date:   Wed Oct 15 17:53:11 2014 +0200

     Rename some defines containing FAT in their name to be filesystem 
generic

     Rename some defines containing FAT in their name to be filesystem 
generic:
     MMCSD_MODE_FAT => MMCSD_MODE_FS
     CONFIG_SPL_FAT_LOAD_ARGS_NAME => CONFIG_SPL_FS_LOAD_ARGS_NAME
     CONFIG_SPL_FAT_LOAD_PAYLOAD_NAME => CONFIG_SPL_FS_LOAD_PAYLOAD_NAME
     CONFIG_SYS_MMC_SD_FAT_BOOT_PARTITION => 
CONFIG_SYS_MMC_SD_FS_BOOT_PARTITION

     Signed-off-by: Guillaume GARDET <guillaume.gardet at free.fr>
     Cc: Tom Rini <trini at ti.com>
---8<---

>
> Regards,
>
> -- Robert Nelson http://www.rcn-ee.com/

Best Regards,
Bo Shen