[U-Boot] [PATCH] gpio: intel_ich6: Set correct gpio output value in ich6_gpio_direction_output()

Simon Glass sjg at chromium.org
Thu Dec 11 04:22:14 CET 2014


On 7 December 2014 at 14:39, Simon Glass <sjg at chromium.org> wrote:
> On 6 December 2014 at 21:48, Axel Lin <axel.lin at ingics.com> wrote:
>> Current code does not set gpio output value in ich6_gpio_direction_output(),
>> fix it.
>>
>> Signed-off-by: Axel Lin <axel.lin at ingics.com>
>> ---
>>  drivers/gpio/intel_ich6_gpio.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpio/intel_ich6_gpio.c b/drivers/gpio/intel_ich6_gpio.c
>> index b095d17..92c23ae 100644
>> --- a/drivers/gpio/intel_ich6_gpio.c
>> +++ b/drivers/gpio/intel_ich6_gpio.c
>> @@ -251,6 +251,8 @@ static int ich6_gpio_direction_output(struct udevice *dev, unsigned offset,
>>         struct ich6_bank_priv *bank = dev_get_priv(dev);
>>         u32 tmplong;
>>
>> +       gpio_set_value(offset, value);
>> +
>>         tmplong = inl(bank->io_sel);
>>         tmplong &= ~(1UL << offset);
>>         outl(bank->io_sel, tmplong);
>> --
>> 1.9.1
>>
>
> Acked-by: Simon Glass <sjg at chromium.org>

Applied to u-boot-x86 - thanks!

- Simon


More information about the U-Boot mailing list