[U-Boot] [PATCH 2/2] Kconfig: Move CONFIG_SYS_MALLOC_F_LEN to Kconfig
Simon Glass
sjg at chromium.org
Thu Dec 11 19:44:12 CET 2014
Hi Masahiro,
On 11 December 2014 at 10:53, Masahiro YAMADA <yamada.m at jp.panasonic.com> wrote:
> Hi Simon,
>
>
> 2014-12-09 22:21 GMT+09:00 Simon Glass <sjg at chromium.org>:
>> diff --git a/arch/arm/cpu/armv7/tegra-common/Kconfig b/arch/arm/cpu/armv7/tegra-common/Kconfig
>> index 898e86d..9c98d19 100644
>> --- a/arch/arm/cpu/armv7/tegra-common/Kconfig
>> +++ b/arch/arm/cpu/armv7/tegra-common/Kconfig
>> @@ -17,6 +17,9 @@ config TEGRA124
>>
>> endchoice
>>
>> +config SYS_MALLOC_F_LEN
>> + default 0x1800
>> +
>
>
> I do not object against your way now, but it seems unfortunate because
> I think this kind of stuff should go to _defconfig.
>
> The problem is that we have much more defconfig files than Linux
> without much differences but we do not have something like
> tegra-common_defconfig.
>
> I have been thinking of this these days.
>
> Perhaps, one possible solution I have come up with is to use
> scripts/kconfig/merge_config.sh
> For example,
>
> - "make tegra30_defconfig" + tegra30_harmony.config -> Harmony board
> - "make tegra30_defconfig" + tegra30_seaboard.config -> Seaboard
>
Yes something like this was the discussion I was wanting to have.
As you can see I found myself adding things to Kconfig to avoid
needing to add loads of common stuff to multiple files. It otherwise
rapidly becomes unmaintainable I think. I personally find the kernel
Kconfigs a pain in that way - in Chrome OS we have a config merging
script to try to make it less painful. Something like you proposed
would solve this, but IMO it should be part of the build system, not
hacked in by each vendor.
Regards,
Simon
More information about the U-Boot
mailing list