[U-Boot] [PATCH 16/25] x86: Integrate Tunnel Creek processor microcode

[Simon Glass]

Hi Bin,

On 15 December 2014 at 19:28, Bin Meng <bmeng.cn at gmail.com> wrote:
> Hi Pavel,
>
> On Tue, Dec 16, 2014 at 6:34 AM, Pavel Machek <pavel at denx.de> wrote:
>> On Thu 2014-12-04 23:02:46, Bin Meng wrote:
>>> Integrate the processor microcode version 1.05 for Tunnel Creek,
>>> CPUID device 20661h.
>>>
>>> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
>>> ---
>>>  arch/x86/cpu/queensbay/M0220661105.inc | 1288 ++++++++++++++++++++++++++++++++
>>>  1 file changed, 1288 insertions(+)
>>>  create mode 100644 arch/x86/cpu/queensbay/M0220661105.inc
>>>
>>> diff --git a/arch/x86/cpu/queensbay/M0220661105.inc b/arch/x86/cpu/queensbay/M0220661105.inc
>>> new file mode 100644
>>> index 0000000..f2b2b4e
>>> --- /dev/null
>>> +++ b/arch/x86/cpu/queensbay/M0220661105.inc
>>> @@ -0,0 +1,1288 @@
>>> +/*
>>> + * Copyright (C) 2013, Intel Corporation
>>> + *
>>> + * SPDX-License-Identifier:  Intel
>>
>> Can we get the file under GPLv2+?
>
> I believe it is hard for Intel to release the microcode under GPLv2+ ...
>
>>> + */
>>> +
>>> +/* External Header */
>>
>> Comment here that this is processor microcode would be nice. And maybe
>> more self-describing filename?
>
> The file name is extracted from Intel released microcode.dat. We
> intend to use the same name to keep track of what version is used
> here. Simon is working on patches to convert this to dtsi format, so
> we can generate comments there from the microcode tool, Simon?

Yes the tool generates comments.

Regards,
Simon