[U-Boot] [PATCH] spi: designware_spi: Fix off-by-one for checking fifo depth

Axel Lin axel.lin at ingics.com
Fri Dec 19 05:40:32 CET 2014


The depth could be from 2 to 256 from HW spec, so fix off-by-one for checking
fifo depth.

Signed-off-by: Axel Lin <axel.lin at ingics.com>
---
Hi,
I don't have this hardware handy, so please test it.
 drivers/spi/designware_spi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/designware_spi.c b/drivers/spi/designware_spi.c
index 98c9f03..14d0c23 100644
--- a/drivers/spi/designware_spi.c
+++ b/drivers/spi/designware_spi.c
@@ -164,7 +164,7 @@ static void spi_hw_init(struct dw_spi_priv *priv)
 	if (!priv->fifo_len) {
 		u32 fifo;
 
-		for (fifo = 2; fifo <= 257; fifo++) {
+		for (fifo = 2; fifo <= 256; fifo++) {
 			dw_writew(priv, DW_SPI_TXFLTR, fifo);
 			if (fifo != dw_readw(priv, DW_SPI_TXFLTR))
 				break;
-- 
1.9.1





More information about the U-Boot mailing list