[U-Boot] [PATCH RFT 2/2] davinci: Do not duplicate setting of gd

Tom Rini trini at ti.com
Sun Dec 21 23:01:07 CET 2014


On Mon, Dec 22, 2014 at 08:34:11AM +1100, Peter Howard wrote:
> On Fri, 2014-12-19 at 16:53 -0500, Tom Rini wrote:
> > In f0c3a6c we stopped setting gd in board_init_f, but later had to
> > revert to due problems on certain platforms.  As davinci does not look
> > to have these problems, we can drop the setting here and rely upon
> > crt0.S to do it.
> > 
> > Cc: Peter Howard <pjh at northern-ridge.com.au>
> > Signed-off-by: Tom Rini <trini at ti.com>
> > 
> > ---
> > Peter, I don't have my davinci board hooked up but since you were doing
> > some changes recently is there a chance you can test this easily?
> > Thanks!
> 
> Applied this patch (with and without 1/1 as well - given part 1 is ARMv7
> it shouldn't have any bearing on davinci but wanted to be sure).
> 
> U-boot doesn't boot on the da850evm with this change.  I tried both with
> my changes to the generic board, and on a fresh clone of u-boot.git. And
> on u-boot-ti.git.  I haven't looked further, but I'm guessing there is
> early access to gd of the sort you patched out for v7.

Thanks for testing, I feared it wasn't quite as easy as it looked, I'll
have a think about it and see if I can recall what else might be
tickling gd that early over there.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141221/bc48543b/attachment.pgp>


More information about the U-Boot mailing list