[U-Boot] [PATCH 6/7] Use PRIx32 etc. to print out 32bit-width variable (MAD)

Simon Glass sjg at chromium.org
Tue Dec 23 05:48:59 CET 2014


Hi Masahiro,

On 22 December 2014 at 03:16, Masahiro Yamada <yamada.m at jp.panasonic.com> wrote:
> If <stdint.h> is included, the definition of fixed-width types
> are compiler-dependent.
>
> For example, some compilers use "unsigned long" and some compilers
> use "unsigned int" for 32bit width typedefs.
>
> That means, we can no longer use hard-code "%x" or "%d"
> to print 32bit-width variables.
>
> We use printf() everywhere to print 32bit variables.
>
> This commit only fixes fs/fat/fat.c because I cannot imagine
> how many days I have to spend to eliminate all the warnings.
> (Of course, I do not think we should do such ridiculous things.)
>
> Just in case, I put the warnings I got for Panda board below:

Yes indeed, this patch is ugly. We need to keep 32-bit types
consistent. I felt it was possible to live with 64-bit types being
inconsistent because 64-bit printf()s are so rare. But it would be
better to avoid the inconsistency altogether.

Regards,
Simon


More information about the U-Boot mailing list