[U-Boot] [PATCH 2/9] sunxi: Move SPL s_init() code to board_init_f()

[Simon Glass]

Hi Ian,

On 28 December 2014 at 02:19, Ian Campbell <ijc at hellion.org.uk> wrote:
> On Tue, 2014-12-23 at 12:04 -0700, Simon Glass wrote:
>
>> +void board_init_f(ulong dummy)
>> +{
> [...]
>> +     /* Clear the BSS. */
>> +     memset(__bss_start, 0, __bss_end - __bss_start);
>> +
>> +     board_init_r(NULL, 0);
>
> The previous (__weak) version of board_init_f also sets gd, which you've
> also removed from s_init here and not added back anywhere (indeed, this
> is the point...). But where is gd initialised now?

It's still in start.S, I've just removed this duplicate.

>
> The patch generally looks good, two quick questions: has it been tested
> in both FEL and regular mode, and has it been tested with a "legacy" as
> well as a driver model system? (I might be able to find time in a day or
> two to answer these myself, but for now I'll just ask).

I haven't tried FEL, I only just heard of it in your email. I'll see
if I can figure out how to test that.

I don't think this patch affects any drivers, but I can test that too.

Regards,
Simon