[U-Boot] [PATCH 15/17] sunxi: Ippo_q8h defconfigs: Enable the LCD panel found on these tablets.

Hans de Goede hdegoede at redhat.com
Mon Dec 29 20:31:20 CET 2014


Hi,

On 29-12-14 16:56, Chen-Yu Tsai wrote:
> On Mon, Dec 29, 2014 at 9:57 PM, Ian Campbell <ijc at hellion.org.uk> wrote:
>> On Fri, 2014-12-26 at 14:44 +0800, Chen-Yu Tsai wrote:
>>>> So if I'm not mistaken for the Ippo_q8h_v5 the timings should be:
>>>>
>>>> CONFIG_VIDEO_LCD_MODE="x:800,y:480,depth:18,pclk_khz:33000,le:87,ri:168,up:31,lo:13,hs:1,vs:1,sync:0,vmode:0"
>>>
>>>
>>> The new values look better.
>>
>> Thanks. I've not seen a v2 of this patch, but assuming a patch with
>> these new values were to be posted I would say:
>>      Acked-by: Ian Campbell <ijc at hellion.org.uk>
>>
>> I think we should add your Tested-by too.
>
> Tested-by: Chen-Yu Tsai <wens at csie.org>

Thanks, I've added both the Acked-by  and the Tested-by to the commit in
my personal tree, which has the new values.

Regards,

Hans


More information about the U-Boot mailing list