[U-Boot] [PATCH 7/9] imx: woodburn: Remove reference to gdata

Stefano Babic sbabic at denx.de
Tue Dec 30 13:10:23 CET 2014


Hi Simon,

On 23/12/2014 20:04, Simon Glass wrote:
> The global_data pointer (gd) has already been set before board_init_f()
> is called. We should not assign it again. We should also not use gdata since
> it is going away.
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
> 
>  board/woodburn/woodburn.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/board/woodburn/woodburn.c b/board/woodburn/woodburn.c
> index 2744514..3da61a4 100644
> --- a/board/woodburn/woodburn.c
> +++ b/board/woodburn/woodburn.c
> @@ -137,9 +137,6 @@ void board_init_f(ulong dummy)
>  	/* Clear the BSS. */
>  	memset(__bss_start, 0, __bss_end - __bss_start);
>  
> -	/* Set global data pointer. */
> -	gd = &gdata;
> -
>  	preloader_console_init();
>  	timer_init();
>  

Agree on this concept.

Acked-by: Stefano Babic <sbabic at denx.de>

Best regards,
Stefano Babic



-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================


More information about the U-Boot mailing list