[U-Boot] [PATCH 1/8] imx: i2c: Zap unnecessary malloc() calls

Marek Vasut marex at denx.de
Tue Dec 30 16:34:02 CET 2014


On Tuesday, December 30, 2014 at 02:34:47 PM, Stefano Babic wrote:
> On 16/12/2014 14:09, Marek Vasut wrote:
> > The malloc() calls are unnecessary, just allocate the stuff on stack.
> > While at it, reorder the code a little, so that only one variable is
> > used for the text, use snprintf() instead of sprintf() and use %01d
> > as a formatting string to avoid any possible overflows.
> > 
> > Signed-off-by: Marek Vasut <marex at denx.de>
> > Cc: Igor Grinberg <grinberg at compulab.co.il>
> > Cc: Nikita Kiryanov <nikita at compulab.co.il>
> > Cc: Sean Cross <xobs at kosagi.com>
> > Cc: Simon Glass <sjg at chromium.org>
> > Cc: Stefano Babic <sbabic at denx.de>
> > Cc: Tim Harvey <tharvey at gateworks.com>
> > ---
> 
> Applied to u-boot-imx, thanks !

Hey!

hope you had a nice holiday :) You might want to apply 2/8 and 3/8 to current 
codebase and send it to Tom, since they fix real problem and the board doesn't
boot without this. I should have separated them out, sorry.

Best regards,
Marek Vasut


More information about the U-Boot mailing list