[U-Boot] [PATCH] tam3517: fix NAND detection

Gupta, Pekon pekon at ti.com
Mon Jun 2 09:30:54 CEST 2014


>From: Stefano Babic [mailto:sbabic at denx.de]
[...]

>>> diff --git a/include/configs/tam3517-common.h b/include/configs/tam3517-common.h
>>> index 3522c1a..bd117d5 100644
>>> --- a/include/configs/tam3517-common.h
>>> +++ b/include/configs/tam3517-common.h
>>> @@ -185,6 +185,7 @@
>>> /* Configure the PISMO */
>>> #define PISMO1_NAND_SIZE		GPMC_SIZE_128M
>>>
>>> +#define CONFIG_NAND
>>
>> You should not add CONFIG_NAND directly to include/configs/...
>> instead this should come from board profiles defined in boards.cfg
>> refer am335x_evm or description given in header of boards.cfg
>>
>
>But TAM3517 is a SOM and it has always NAND. It is slightly different as
>the am335x_evm. All boards using this SOM are then affected by this
>problem, and fixing it in the SOM configuration file let us to make a
>global fix for all boards, instead of adding CONFIG_NAND for each single
>profile in boards.cfg.
>
Oh sorry, yes I forgot it’s a OMAP3 variant (same family).
So this can also be added to include/configs/ti_omap3_common.h
But as you are not re-using that config file, please proceed with above change.


with regards, pekon


More information about the U-Boot mailing list