[U-Boot] [RFC PATCH 03/22] dm: Make sure that the root device is probed

Simon Glass sjg at chromium.org
Tue Jun 3 03:59:49 CEST 2014


Hi Marek,

On 1 June 2014 11:33, Marek Vasut <marex at denx.de> wrote:
> On Saturday, May 24, 2014 at 11:21:02 PM, Simon Glass wrote:
>> The root device should be probed just like any other device. The effect of
>> this is to mark the device as activated, so that it can be removed (along
>> with its children) if required.
>>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>> ---
>>
>>  drivers/core/root.c | 3 +++
>>  test/dm/core.c      | 2 +-
>>  2 files changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/core/root.c b/drivers/core/root.c
>> index 4427b81..9fff164 100644
>> --- a/drivers/core/root.c
>> +++ b/drivers/core/root.c
>> @@ -48,6 +48,9 @@ int dm_init(void)
>>       ret = device_bind_by_name(NULL, &root_info, &DM_ROOT());
>
> Off-topic: This &DM_ROOT() above looks a little suspicious, don't you think?

Yes. I wonder if it should not be written as a function?

Regards,
Simon


More information about the U-Boot mailing list