[U-Boot] [PATCH v2 1/5] Exynos: SPI: Fix reading data from SPI flash

Simon Glass sjg at chromium.org
Tue Jun 3 16:24:53 CEST 2014


On 3 June 2014 08:23, Simon Glass <sjg at chromium.org> wrote:
> HI Akshay,
>
> On 3 June 2014 06:37, Akshay Saraswat <akshay.s at samsung.com> wrote:
>> SPI recieve and transfer code in exynos_spi driver has a logical bug.
>> We read data in a variable which can hold an integer. Then we assign
>> this integer 32 bit value to another variable which has data type uchar.
>> Latter represents a unit of our recieve buffer. Everytime when we write
>> a value to our recieve buffer we step ahead by 4 units when actually we
>> wrote to one unit. This results in the loss of 3 bytes out of every 4
>> bytes recieved. This patch intends to fix this bug.
>>
>> Signed-off-by: Akshay Saraswat <akshay.s at samsung.com>
>
> Acked-by: Simon Glass <sjg at chromium.org>

Tested on pit using saveenv
Tested-by: Simon Glass <sjg at chromium.org>


More information about the U-Boot mailing list