[U-Boot] [PATCH 09/12] sunxi: Add axp152 pmic support

Hans de Goede hdegoede at redhat.com
Tue Jun 3 19:31:42 CEST 2014


Hi,

On 05/31/2014 07:10 PM, Ian Campbell wrote:
> On Fri, 2014-05-30 at 11:06 +0200, Hans de Goede wrote:
>> Add support for the x-powers axp152 pmic which is found on most A10s boards.
>
> This driver looks superficially very similar to the last one, have you
> considered merging them?
>
> Other than that most of the generic questions I had on the last one seem
> to appear here too, magic numbers and so on.

The AXP152 and AXP209 look similar, but they have different register
addresses, different ranges for the LDO-s, different number of DCDC
convertors, etc. Doing both in one driver would very quickly become
a very ugly #ifdef fest.

I've applied similar fixes as to the AXP209 driver.

Regards,

Hans


More information about the U-Boot mailing list