[U-Boot] error when building env

[Tom Rini]

On Mon, May 19, 2014 at 02:14:03PM +0200, Luka Perkov wrote:
> Hi Tom,
> 
> On Fri, May 16, 2014 at 01:58:05PM -0400, Tom Rini wrote:
> > On Fri, May 16, 2014 at 07:26:51PM +0200, Luka Perkov wrote:
> > > when trying to build env with "-mfloat-abi=hard" I'm hitting this error:
> > > 
> > > /opt/openwrt/trunk/staging_dir/toolchain-arm_cortex-a9+neon_gcc-4.8-linaro_uClibc-0.9.33.2_eabi/bin/arm-openwrt-linux-uclibcgnueabi-gcc  -o tools/env/fw_printenv_unstripped tools/env/fw_env.o tools/env/fw_env_main.o tools/env/crc32.o tools/env/ctype.o tools/env/linux_string.o tools/env/env_attr.o tools/env/env_flags.o tools/env/aes.o  
> > > /opt/build/owrt_staging_dir/toolchain-arm_cortex-a9+neon_gcc-4.8-linaro_uClibc-0.9.33.2_eabi/bin/../lib/gcc/arm-openwrt-linux-uclibcgnueabi/4.8.3/../../../../arm-openwrt-linux-uclibcgnueabi/bin/ld: error: tools/env/fw_printenv_unstripped uses VFP register arguments, tools/env/fw_env.o does not
> > 
> > Odd.  I can build 'tools-only' with my hard float toolchain fine.  Can
> > you build with V=1 and see what files are perhaps not getting passed in
> > a -mfloat option?
> 
> The patch below fixes the problem I was having. Is that good enough for
> proper patch submission?
> 
> With it I am able to use replace default HOSTCFLAGS with what was
> defined in TARGET_CFLAGS.
> 
> Luka
> 
> diff --git a/tools/env/Makefile b/tools/env/Makefile
> index f5368bc..4de1d51 100644
> --- a/tools/env/Makefile
> +++ b/tools/env/Makefile
> @@ -10,6 +10,10 @@
>  # with "CC" here for the maximum code reuse of scripts/Makefile.host.
>  HOSTCC = $(CC)
>  
> +ifneq ($(TARGET_CFLAGS),)
> +HOSTCFLAGS = $(TARGET_CFLAGS)
> +endif
> +
>  # Compile for a hosted environment on the target
>  HOST_EXTRACFLAGS  = $(patsubst -I%,-idirafter%, $(UBOOTINCLUDE)) \
>  		-idirafter $(srctree)/tools/env \

This still seems odd.  Masahiro?

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140605/a21e949c/attachment.pgp>