[U-Boot] [PATCH] arm: fix a double-definition error of _start symbol

Albert ARIBAUD albert.u.boot at aribaud.net
Mon Jun 9 10:40:59 CEST 2014


Hi Masahiro,

On Tue, 27 May 2014 11:16:29 +0900, Masahiro Yamada
<yamada.m at jp.panasonic.com> wrote:

> The symbol "_start" is defined twice in arch/arm/lib/vectors.S:
> around line 48 and line 54.
> 
> If CONFIG_SYS_DV_NOR_BOOT_CFG is defined (as on calimain board),
> build fails:
> 
>   arch/arm/lib/vectors.S: Assembler messages:
>   arch/arm/lib/vectors.S:54: Error: symbol `_start' is already defined
>   make[1]: *** [arch/arm/lib/vectors.o] Error 1
>   make: *** [arch/arm/lib] Error 2

Apart from the shame of having written this double definition myself and
missed it entirely, I am surprised because this error (obviously) does
not occur on my setup. Which toolchain are you using?

Anyway:

> Signed-off-by: Masahiro Yamada <yamada.m at jp.panasonic.com>
> Cc: Albert ARIBAUD <albert.u.boot at aribaud.net>
> ---
>  arch/arm/lib/vectors.S | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm/lib/vectors.S b/arch/arm/lib/vectors.S
> index fad00da..493f337 100644
> --- a/arch/arm/lib/vectors.S
> +++ b/arch/arm/lib/vectors.S
> @@ -45,8 +45,6 @@
>   *************************************************************************
>   */
>  
> -_start:
> -
>  #ifdef CONFIG_SYS_DV_NOR_BOOT_CFG
>  	.word	CONFIG_SYS_DV_NOR_BOOT_CFG
>  #endif

Applied to u-boot-arm/master, thanks!

Amicalement,
-- 
Albert.


More information about the U-Boot mailing list