[U-Boot] [PATCH] common: hash: zero end the string instead of the pointer

Jeroen Hofstee jeroen at myspectrum.nl
Mon Jun 9 11:02:02 CEST 2014


if algo->digest_size is zero nothing is set in the str_output
buffer. An attempt is made to zero end the buffer, but the
pointer to the buffer is set to zero instead. I am unaware if
it causes any actual problems, but solves the following warning:

common/hash.c:217:13: warning: expression which evaluates to zero treated as
a null pointer constant of type 'char *' [-Wnon-literal-null-conversion]
                str_ptr = '\0';
                          ^~~~

cc: Simon Glass <sjg at chromium.org>
Signed-off-by: Jeroen Hofstee <jeroen at myspectrum.nl>
---
 common/hash.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/hash.c b/common/hash.c
index 7627b84..040eead 100644
--- a/common/hash.c
+++ b/common/hash.c
@@ -214,7 +214,7 @@ static void store_result(struct hash_algo *algo, const u8 *sum,
 			sprintf(str_ptr, "%02x", sum[i]);
 			str_ptr += 2;
 		}
-		str_ptr = '\0';
+		*str_ptr = '\0';
 		setenv(dest, str_output);
 	} else {
 		ulong addr;
-- 
1.8.3.2



More information about the U-Boot mailing list