[U-Boot] [PATCH] arm: fix a build error with CONFIG_USE_IRQ

Masahiro Yamada yamada.m at jp.panasonic.com
Mon Jun 9 13:19:38 CEST 2014


Hi Albert,



> Sorry, I though your patch was about CONFIG_USE_IRQ and its related
> feature, as the subject and commit message both heavily refer to it
> and mention CONFIG_SYS_DV_NOR_BOOT_CFG almost incidentally.
> 
> Since the issue is that CONFIG_SYS_DV_NOR_BOOT_CFG definition is broken
> for three mainline targets, then then please repost a V2 of your
> patch, with an amended commit message (and subject) which make it clear
> that the problem is with CONFIG_SYS_DV_NOR_BOOT_CFG breaking these
> boards, not with CONFIG_USE_IRQ which is unused anyway. I will then make
> sure to apply your V2 patch ASAP as it is a bug fix.
> 

The CONFIG_SYS_DV_NOR_BOOT_CFG problem cannot be detected
by build test only.

Because you only check if all ARM boards succeed in compile or not,
I thought  CONFIG_USE_IRQ problem would be clearer to understand.

But  the fact was opposite from my expectation.  :-(


Anyway,  I've posted  v2  with amended comments.


Best Regards
Masahiro Yamada




More information about the U-Boot mailing list