[U-Boot] [PATCH v2 0/2] ARM: bug fixes of commit 41623c91 (arch/arm/lib/vectors.S)

[Albert ARIBAUD]

Hi Masahiro,

On Mon,  9 Jun 2014 20:16:52 +0900, Masahiro Yamada
<yamada.m at jp.panasonic.com> wrote:

> 
> Masahiro Yamada (2):
>   arm: include config.h in arch/arm/lib/vectors.S
>   arm: fix a double-definition error of _start symbol
> 
>  arch/arm/lib/vectors.S | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

NAK on both patches.

1/2 commit message should drop any reference to CONFIG_USE_IRQ and
limit itself to the visible and actual issue it solves, that is,
the missing prefix word in the images of boards which define
CONFIG_SYS_DV_NOR_BOOT_CFG.

2/2 is redundant as a standalone version of it has already been applied
to u-boot-arm/master -- and I'm not going to roll back a legitimate fix.

Note BTW that the order in which the patches are listed here is wrong:
it actively breaks the building of three boards. While I do understand
that it is done on purpose for didactic reasons, I don't want a commit
that breaks builds if I can avoid it, as such a commit makes things
like git bisect (more) prone to failure (than they already are). In
order to avoid breaking builds, patch 2/2 would have had to come before
patch 1/2.

I do share your general concern that broken feature should be fixed, and
an unused one should be removed, and as I said, I am working on removing
CONFIG_USE_IRQ, all the more as no one seemd to notice it was broken.
After all, you only noticed it incidentally.

I do understand too that you want this fixed quickly. It is a property
of an open source project that it both thrives /and/ depends on people
contributing. If you feel the CONFIG_USE_IRQ feature should be removed
quicker than I (or someone else) can contribute a patch for it, please
feel free to contribute such a patch yourself (possibly in V3 of this
series in replacement of the current 2/2) -- I won't compete with you,
since such a patch will /save/ me some time.

Amicalement,
-- 
Albert.