[U-Boot] [PATCH] socfpga: Relocate arch common functions away from board

[Chin Liang See]

Hi Albert,

On Tue, 2014-06-10 at 09:07 +0200, ZY - albert.u.boot wrote:
> Hi Chin,
> 
> On Tue, 10 Jun 2014 01:41:06 -0500, Chin Liang See <clsee at altera.com>
> wrote:
> 
> > To move the arch common function away from board folder to
> > arch/arm/cpu/armv7/socfpga folder.
> > 
> > Signed-off-by: Chin Liang See <clsee at altera.com>
> > Cc: Wolfgang Denk <wd at denx.de>
> > Cc: Detlev Zundel <dzu at denx.de>
> > Cc: Pavel Machek <pavel at denx.de>
> > Cc: Dinh Nguyen <dinguyen at altera.com>
> > ---
> >  arch/arm/cpu/armv7/socfpga/misc.c       |   24 ++++++++++++++++++++++++
> >  board/altera/socfpga/socfpga_cyclone5.c |   23 -----------------------
> >  2 files changed, 24 insertions(+), 23 deletions(-)
> > 
> > diff --git a/arch/arm/cpu/armv7/socfpga/misc.c b/arch/arm/cpu/armv7/socfpga/misc.c
> > index 2f1c716..5268f2c 100644
> > --- a/arch/arm/cpu/armv7/socfpga/misc.c
> > +++ b/arch/arm/cpu/armv7/socfpga/misc.c
> > @@ -14,3 +14,27 @@ int dram_init(void)
> >  	gd->ram_size = get_ram_size((long *)PHYS_SDRAM_1, PHYS_SDRAM_1_SIZE);
> >  	return 0;
> >  }
> > +
> > +#if defined(CONFIG_DISPLAY_CPUINFO)
> > +/*
> > + * Print CPU information
> > + */
> > +int print_cpuinfo(void)
> > +{
> > +	puts("CPU   : Altera SOCFPGA Platform\n");
> > +	return 0;
> > +}
> > +#endif
> > +
> > +#if defined(CONFIG_SYS_CONSOLE_IS_IN_ENV) && \
> > +defined(CONFIG_SYS_CONSOLE_OVERWRITE_ROUTINE)
> > +int overwrite_console(void)
> > +{
> > +	return 0;
> > +}
> > +#endif
> > +
> > +int misc_init_r(void)
> > +{
> > +	return 0;
> > +}
> > diff --git a/board/altera/socfpga/socfpga_cyclone5.c b/board/altera/socfpga/socfpga_cyclone5.c
> > index a960eb6..f366565 100644
> > --- a/board/altera/socfpga/socfpga_cyclone5.c
> > +++ b/board/altera/socfpga/socfpga_cyclone5.c
> > @@ -12,17 +12,6 @@
> >  
> >  DECLARE_GLOBAL_DATA_PTR;
> >  
> > -#if defined(CONFIG_DISPLAY_CPUINFO)
> > -/*
> > - * Print CPU information
> > - */
> > -int print_cpuinfo(void)
> > -{
> > -	puts("CPU   : Altera SOCFPGA Platform\n");
> > -	return 0;
> > -}
> > -#endif
> > -
> >  /*
> >   * Print Board information
> >   */
> > @@ -49,18 +38,6 @@ int board_init(void)
> >  	return 0;
> >  }
> >  
> > -int misc_init_r(void)
> > -{
> > -	return 0;
> > -}
> > -
> > -#if defined(CONFIG_SYS_CONSOLE_IS_IN_ENV) && defined(CONFIG_SYS_CONSOLE_OVERWRITE_ROUTINE)
> > -int overwrite_console(void)
> > -{
> > -	return 0;
> > -}
> > -#endif
> > -
> >  /*
> >   * DesignWare Ethernet initialization
> >   */
> 
> Can you clarify in the commit message why this change is needed or
> useful?
> 

Sure, let me send out the v2.
Its to avoid code duplication for other non Altera board which use
socfpga.
Thanks

Chin Liang


> Amicalement,