[U-Boot] [PATCH] common/cli_hush.c: remove unnecessary double braces

Jeroen Hofstee jeroen at myspectrum.nl
Wed Jun 11 00:28:47 CEST 2014


Clang interpretes an if condition like  "if ((a = b) == NULL)
as it tries to assign a value in a statement. Hence if you do
"if ((something)) it warns you that you might be confused.
Hence drop the double braces for plane if statements.

Simon Glass <sjg at chromium.org>
Signed-off-by: Jeroen Hofstee <jeroen at myspectrum.nl>
---
 common/cli_hush.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/common/cli_hush.c b/common/cli_hush.c
index e0c436f..38da5a0 100644
--- a/common/cli_hush.c
+++ b/common/cli_hush.c
@@ -1840,7 +1840,7 @@ static int run_list_real(struct pipe *pi)
 		if (rmode == RES_DO) {
 			if (!flag_rep) continue;
 		}
-		if ((rmode == RES_DONE)) {
+		if (rmode == RES_DONE) {
 			if (flag_rep) {
 				flag_restore = 1;
 			} else {
@@ -3569,7 +3569,7 @@ static char **make_list_in(char **inp, char *name)
 		p3 = insert_var_value(inp[i]);
 		p1 = p3;
 		while (*p1) {
-			if ((*p1 == ' ')) {
+			if (*p1 == ' ') {
 				p1++;
 				continue;
 			}
-- 
1.8.3.2



More information about the U-Boot mailing list