[U-Boot] [PATCH] common/xyzModem.c: move empty statements to newline

Jeroen Hofstee jeroen at myspectrum.nl
Wed Jun 11 01:04:42 CEST 2014


To prevent a warning for clang the loop without a body
is made more clear by moving it to a line of its own.
This prevents a clang warning.

cc: sbabic at denx.de
Signed-off-by: Jeroen Hofstee <jeroen at myspectrum.nl>

---
This ignores checkpatch warnings since somone forgot to burn
the GNU code style manual.

jeroen at yellow:~/software/u-boot$ ./scripts/checkpatch.pl 0001-common-xyzModem.c-move-empty-statements-to-newline.patch
WARNING: please, no spaces at the start of a line
+      while ((c = (*getc) ()) > -1)$

ERROR: code indent should use tabs where possible
+        ;$

WARNING: please, no spaces at the start of a line
+        ;$
---
 common/xyzModem.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/common/xyzModem.c b/common/xyzModem.c
index 39f7d17..56f4bca 100644
--- a/common/xyzModem.c
+++ b/common/xyzModem.c
@@ -759,7 +759,8 @@ xyzModem_stream_terminate (bool abort, int (*getc) (void))
        * If we don't eat it now, RedBoot will think the user typed it.
        */
       ZM_DEBUG (zm_dprintf ("Trailing gunk:\n"));
-      while ((c = (*getc) ()) > -1);
+      while ((c = (*getc) ()) > -1)
+        ;
       ZM_DEBUG (zm_dprintf ("\n"));
       /*
        * Make a small delay to give terminal programs like minicom
-- 
1.8.3.2



More information about the U-Boot mailing list