[U-Boot] [PATCH 1/4] Reactivate the tracing feature
Masahiro Yamada
yamada.m at jp.panasonic.com
Fri Jun 13 04:56:16 CEST 2014
Hi Simon
On Wed, 11 Jun 2014 23:42:25 -0400
Simon Glass <sjg at chromium.org> wrote:
> Hi Masahiro,
>
> On 10 June 2014 00:47, Masahiro Yamada <yamada.m at jp.panasonic.com> wrote:
> > Hi Simon,
> >
> >
> > On Thu, 5 Jun 2014 12:27:49 -0600
> > Simon Glass <sjg at chromium.org> wrote:
> >
> >> This was lost sometime in the Kbuild conversion. Add it back.
> >
> > Not lost.
> > It was moved to examples/Makefile.
> >
> >
> > Prior to Kbuild conversion, config.mk was like this:
> >
> > ------------------>8----------------------
> > BCURDIR = $(subst $(SRCTREE)/,,$(CURDIR:$(obj)%=%))
> >
> > ifeq ($(findstring examples/,$(BCURDIR)),)
> > ifeq ($(CONFIG_SPL_BUILD),)
> > ifdef FTRACE
> > CFLAGS += -finstrument-functions -DFTRACE
> > endif
> > endif
> > endif
> > --------------------8<-------------------------
> >
> >
> > "-finstrument-functions -DFTRACE" was enabled
> > only under examples/ directory.
> > (Do you remember why?)
> >
> > That's why I moved it to examples/Makefile
> > to keep the equivalent behavior.
>
> I don't think it is the same. In my code I was trying to make sure
> there was NO tracing in example directory, and SPL. I think I should
> go the same way, so will update my patch.
>
> >
Oops. I totally screwed up.
So sorry. I'm crazy.
"-finstrument-functions -DFTRACE" must be __disabled__
under examples/ and spl/.
I broke FTRACE feature. My apologies.
Best Regards
Masahiro Yamada
More information about the U-Boot
mailing list